Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ReportActionContextMenu up for grouped ReportActionItems #1948

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Move ReportActionContextMenu up for grouped ReportActionItems #1948

merged 1 commit into from
Mar 19, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Mar 19, 2021 •
edited
Loading

Details

For grouped ReportActionItem, shift the context menu up and out of the way of any text.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/157893

Tests

QA Steps

  1. Either add a user to the reportActionContextMenu beta in Betatify, or open the Chrome Dev Console, go to the Application tab, then go to LocalStorage, search the "beta" key, and add "reportActionContextMenu" to the JSON array.
  2. Write out a long message and copy it to your clipboard. It should be at least long enough to take up multiple lines on your screen without any line breaks.
  3. Send the long message twice in a row. The first one should appear adjacent to your avatar, and the second will appear "grouped" below, not adjacent to an Avatar.
  4. Hover over both messages, and make sure the menu that appears does not cover any text.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

image

Mobile Web

This component does not display on mobile web.

Desktop

image

image

iOS

This component does not display on iOS

Android

This component does not display on Android

@roryabraham roryabraham requested a review from a team as a code owner March 19, 2021 21:05
@roryabraham roryabraham self-assigned this Mar 19, 2021
@botify botify requested review from marcaaron and removed request for a team March 19, 2021 21:06
marcaaron
marcaaron approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change @roryabraham! Looks great ❤️

@marcaaron marcaaron merged commit 2c9f366 into master Mar 19, 2021
@marcaaron marcaaron deleted the Rory-MoveContextMenuUp branch March 19, 2021 23:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@isagoico
Copy link

@roryabraham @marcaaron This PR seems like it didn't make it to staging. We're unable to see the small menu above the messages in the web or desktop app
image

@roryabraham
Copy link
Contributor Author

roryabraham commented Mar 26, 2021 •
edited
Loading

Hi @isagoico, I just edited the PR description to add proper QA steps. The menu is currently hidden behind a beta. Do you have access to the Betatify tool to add yourself to betas? I can't remember... I think not so there's an alternative option to get the menu to appear.

@isagoico
Copy link

No, I think we haven't used the Betatify tool before and don't have access to it.

@roryabraham
Copy link
Contributor Author

image
image

Okay, I QA'd this one myself and it's a pass, so checking it off the deploy checklist!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcaaron marcaaron marcaaron approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roryabraham @OSBotify @isagoico @marcaaron